Bug 260026 – AX: aria-current.html fails in isolated tree mode

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[Joshua Hoffman]

The aria-current.html test fails when run in Isolated Tree Mode.

[Radar WebKit Bug Importer]

<rdar://problem/113698662>

[Joshua Hoffman]

Created attachment 467238 [details]
Patch

[Joshua Hoffman]

Created attachment 467239 [details]
Patch

[EWS]

Committed 266808@main (a5ea28813307): <https://commits.webkit.org/266808@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 467239 [details].

[Andres Gonzalez]

(In reply to Joshua Hoffman from comment #3)
> Created attachment 467239 [details]
> Patch

--- a/LayoutTests/accessibility/aria-current.html
+++ b/LayoutTests/accessibility/aria-current.html

 <p id="description"></p>

As we rework these tests, we are moving away from using the description element and the continuously writing the the console with debug or other means. Instead we declare an output variable to hold all the output and call debug(output) at the end of the test. There are many examples of this pattern throughout the LayoutTests/accessibility dir. This has several advantages, namely, we reduce the source of problems that can occur in ITM to what the test is intended to test, and also the tests run faster.

         for (var i = 0, c = examples.length; i < c; i++) {

for loop control variables should be declared with let instead of var when possible. Also, I don't think you need c, instead you can do I < examples.length

Other local variables like el and expectation may be declared with let as well.

[Andres Gonzalez]

(In reply to Joshua Hoffman from comment #3)
> Created attachment 467239 [details]
> Patch

Another style recommendation, we are starting to flush the <script> code in every test to the left margin instead of indenting everything one extra tab.