Bug 26000 - prepare-ChangeLog should convert windows style backslashes in file paths
: prepare-ChangeLog should convert windows style backslashes in file paths
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: Tools / Tests
: 528+ (Nightly build)
: PC Windows XP
: P2 Normal
Assigned To: Adam Barth
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-05-24 23:31 PDT by Darin Fisher (:fishd, Google)
Modified: 2009-06-16 11:09 PDT (History)
2 users (show)

See Also:


Attachments
patch (3.75 KB, patch)
2009-06-16 00:35 PDT, Adam Barth
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Fisher (:fishd, Google) 2009-05-24 23:31:12 PDT
prepare-ChangeLog should convert windows style backslashes in file paths

if you use a windows build of subversion, then you will end up with backslashes in the file paths of the ChangeLog.  for readability and perhaps to help with scripts that may operate on ChangeLog, we should try to make prepare-ChangeLog smarter.
Comment 1 Adam Barth 2009-06-16 00:35:54 PDT
Created attachment 31338 [details]
patch

This patch also normalizes line ends as well as backslashes.  Yay for platform uniformity!
Comment 2 Adam Barth 2009-06-16 00:37:27 PDT
It's a race to see which Darin reviews this patch first!
Comment 3 Darin Fisher (:fishd, Google) 2009-06-16 07:10:55 PDT
Thanks for patching this, Adam!
Comment 4 Adam Barth 2009-06-16 11:09:31 PDT
http://trac.webkit.org/changeset/44716