Bug 25999 - Chromium build bustage related to PassOwnPtr
Summary: Chromium build bustage related to PassOwnPtr
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Darin Fisher (:fishd, Google)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-05-24 23:16 PDT by Darin Fisher (:fishd, Google)
Modified: 2009-05-25 02:21 PDT (History)
1 user (show)

See Also:


Attachments
v1 patch (1.16 KB, patch)
2009-05-24 23:22 PDT, Darin Fisher (:fishd, Google)
mrowe: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Fisher (:fishd, Google) 2009-05-24 23:16:09 PDT
Chromium build bustage related to PassOwnPtr

Changes:
http://trac.webkit.org/changeset/44098
http://trac.webkit.org/changeset/44099

Build bustage observed here:
http://build.chromium.org/buildbot/waterfall.fyi/builders/Webkit%20(webkit.org)/builds/4277/steps/compile/logs/stdio
Comment 1 Darin Fisher (:fishd, Google) 2009-05-24 23:22:00 PDT
Created attachment 30641 [details]
v1 patch
Comment 2 Mark Rowe (bdash) 2009-05-24 23:25:53 PDT
Comment on attachment 30641 [details]
v1 patch

Build fixes typically don't need review.
Comment 3 Darin Fisher (:fishd, Google) 2009-05-24 23:29:15 PDT
Landed as:  http://trac.webkit.org/changeset/44123
Comment 4 Maciej Stachowiak 2009-05-25 02:21:29 PDT
Although review is not mandatory for build fixes, there's nothing wrong with getting review, especially if there are people around to look at the fix.