Bug 259952 - AX: Initialize the AX thread on first client request.
Summary: AX: Initialize the AX thread on first client request.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Andres Gonzalez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-08-08 16:09 PDT by Andres Gonzalez
Modified: 2023-08-09 11:25 PDT (History)
11 users (show)

See Also:

Attachments
Patch (5.21 KB, patch)
2023-08-08 16:24 PDT, Andres Gonzalez 		no flags Details | Formatted Diff | Diff
Patch (5.21 KB, patch)
2023-08-09 10:01 PDT, Andres Gonzalez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andres Gonzalez 2023-08-08 16:09:16 PDT 
.
Comment 1 Radar WebKit Bug Importer 2023-08-08 16:09:27 PDT 
<rdar://problem/113592230>
Comment 2 Andres Gonzalez 2023-08-08 16:24:21 PDT 
Created attachment 467225 [details]
Patch
Comment 3 Tyler Wilcock 2023-08-08 16:58:56 PDT 
Comment on attachment 467225 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=467225&action=review

> Source/WebCore/accessibility/mac/AXObjectCacheMac.mm:719
> +    if (LIKELY(!isMainThread() || axThreadInitialized))

The latter check (axThreadInitialized) is cheaper, so maybe it should come first?

if (LIKELY(axThreadInitialized || !isMainThread()))
Comment 4 Andres Gonzalez 2023-08-09 10:01:23 PDT 
Created attachment 467231 [details]
Patch
Comment 5 EWS 2023-08-09 11:25:23 PDT 
Committed 266735@main (fbca8d9e20b9): <https://commits.webkit.org/266735@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 467231 [details].