Bug 259947 - Generated attribute setters for nullable enum string types fail when passing null
Summary: Generated attribute setters for nullable enum string types fail when passing ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryan Reno
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-08-08 15:54 PDT by Ryan Reno
Modified: 2023-08-09 08:08 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Reno 2023-08-08 15:54:42 PDT 
If an attribute has an enumeration type it is supposed to silently fail if we pass a value that's not in the enum. However, we should allow null in the case of a nullable attribute.
Comment 1 Radar WebKit Bug Importer 2023-08-08 15:55:00 PDT 
<rdar://problem/113591277>
Comment 2 Ryan Reno 2023-08-08 15:57:25 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/16495
Comment 3 EWS 2023-08-09 08:08:05 PDT 
Committed 266726@main (23551a03b824): <https://commits.webkit.org/266726@main>

Reviewed commits have been landed. Closing PR #16495 and removing active labels.