Bug 259935 - Regression 264089@main: [ews] unapply-patch is consistently failing with an exception
Summary: Regression 264089@main: [ews] unapply-patch is consistently failing with an e...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-08-08 11:06 PDT by Aakash Jain
Modified: 2023-08-09 04:33 PDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2023-08-08 11:06:32 PDT 
unapply-patch is consistently failing with an exception (for patch-based workflow only, this step isn't used for PR based workflows). 
e.g.: https://ews-build.webkit.org/#/builders/34/builds/16308

  File "/var/buildbot/OpenSource/Tools/CISupport/ews-build/steps.py", line 950, in run
    self.setCommand(self.command + ['--keep-jhbuild-directory'])
builtins.AttributeError: 'UnApplyPatch' object has no attribute 'setCommand'


It started failing since last week when buildbot was restarted. Most likely it's a regression from 264089@main (Bug 256740 [ews-build] Convert trivial shell.ShellCommand steps)
Comment 1 Radar WebKit Bug Importer 2023-08-08 16:00:24 PDT 
<rdar://problem/113591649>
Comment 2 Jonathan Bedard 2023-08-08 16:08:22 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/16497
Comment 3 EWS 2023-08-09 04:33:12 PDT 
Committed 266721@main (acd94547f739): <https://commits.webkit.org/266721@main>

Reviewed commits have been landed. Closing PR #16497 and removing active labels.