RESOLVED FIXED 25988
PluginPackage*.cpp cleanup 
https://bugs.webkit.org/show_bug.cgi?id=25988
Summary PluginPackage*.cpp cleanup
Holger Freyther
Reported 2009-05-24 01:27:28 PDT
Currently there is quite some thing that could be shared between PluginPackageWin.cpp, PluginPackageQt.cpp and PluginPackageGtk.cpp. Recently the duplication has created the usual problem that one site was updated, the two others not. Attempt to improve the situation.
Attachments
Move the big m_browserfuncs assignment to PluginPackage.cpp (14.65 KB, patch)
2009-05-24 01:28 PDT, Holger Freyther 		no flags
DetailsFormatted DiffDiff
Move hash and equal to PluginPackage (6.24 KB, patch)
2009-05-24 01:30 PDT, Holger Freyther 		no flags
DetailsFormatted DiffDiff
Cleanup the hash implementation (2.22 KB, patch)
2009-05-24 01:37 PDT, Holger Freyther 		no flags
DetailsFormatted DiffDiff
Update PluginPackageMac.cpp too (5.08 KB, patch)
2009-05-24 21:05 PDT, Holger Freyther 		hausmann: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Holger Freyther
Comment 1 2009-05-24 01:28:58 PDT
Created attachment 30627 [details] Move the big m_browserfuncs assignment to PluginPackage.cpp Move the big set of assignment statements from PluginPackageWin.cpp to PluginPackage.cpp and remove them from PluginPackageQt.cpp and PluginPackageGtk.cpp.
Holger Freyther
Comment 2 2009-05-24 01:30:17 PDT
Created attachment 30628 [details] Move hash and equal to PluginPackage The hash, equal and compare version can be shared between Gtk and Qt. Move them into PluginPackage.cpp and guard the implementation with a #if USE() as the windows version is specialized and will not be happy with the simple implementation.
Holger Freyther
Comment 3 2009-05-24 01:37:07 PDT
Created attachment 30629 [details] Cleanup the hash implementation Small cleanups, less hardcoded magic numbers (two in this case) and the size of UChar.
Maciej Stachowiak
Comment 4 2009-05-24 03:46:34 PDT
Comment on attachment 30627 [details] Move the big m_browserfuncs assignment to PluginPackage.cpp r=me
Maciej Stachowiak
Comment 5 2009-05-24 03:48:16 PDT
Comment on attachment 30628 [details] Move hash and equal to PluginPackage The ifdef should be an ENABLE not a USE, since it's about optional code inside WebKit (ENABLE), not an optional external dependency (USE). Please change that when landing. Otherwise r=me
Maciej Stachowiak
Comment 6 2009-05-24 03:48:33 PDT
Comment on attachment 30629 [details] Cleanup the hash implementation r=me
Holger Freyther
Comment 7 2009-05-24 21:05:31 PDT
Created attachment 30640 [details] Update PluginPackageMac.cpp too I forgot to update PluginPackageMac.cpp which is used by Qt.
Simon Hausmann
Comment 8 2009-05-25 05:04:10 PDT
Comment on attachment 30640 [details] Update PluginPackageMac.cpp too Nice!!
Simon Hausmann
Comment 9 2009-05-25 05:55:56 PDT
Last fix landed in r44129
Note You need to log in before you can comment on or make changes to this bug.