Bug 259843 – Web Inspector: No search results

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Jeff Johnson]

Created attachment 467199 [details]
Screenshot of Safari Technology Preview

Safari Technology Preview 175 (Safari 17.0, WebKit 18617.1.1.2) on macOS (22G74)

Steps to reproduce:
1) Open https://webkit.org
2) Open web inspector
3) Select Sources tab
4) Select global.js in the sidebar
5) Search for "document" in the global.js file

Expected Results: 5 matches

Actual Results: No matches

This bug does not occur in Safari 16.6 (18615.3.12.11.2)

[Jeff Johnson]

Created attachment 467200 [details]
Screenshot of Safari

[Jeff Johnson]

On further investigation, there are no search results anywhere in the web inspector.

[Frances Cornwall]

I tested in STP 175 and Minibrowser. I found that search did not fire when entering text. If you press the done button, and then open up the search panel again, the results will populate correctly. If you attempt to do a further search, you will have to repeat the steps as mentioned before.

Currently investigating a fix for this bug.

[Frances Cornwall]

In FindBanner.js the _inputFieldSearch(event) is not being triggered. (I can see that there is an event listener in the constructor.)

this._inputField.addEventListener("search", this._inputFieldSearch.bind(this), false);

If I add a call to that function (this._inputFieldSearch(event)) in _inputFieldKeyUp(event) the search starts working when typing. 

I am not confident this is the correct solution though.


Frances@MacBook-Air WebKit % git diff
diff --git a/Source/WebInspectorUI/UserInterface/Views/FindBanner.js b/Source/WebInspectorUI/UserInterface/Views/FindBanner.js
index debbf8e67296..df9c4cea0b8f 100644
--- a/Source/WebInspectorUI/UserInterface/Views/FindBanner.js
+++ b/Source/WebInspectorUI/UserInterface/Views/FindBanner.js
@@ -241,6 +241,8 @@ WI.FindBanner = class FindBanner extends WI.NavigationItem
             this._searchBackwards = false;
         else if (event.keyIdentifier === "Enter")
             this._searchKeyPressed = false;
+
+        this._inputFieldSearch(event)
     }
 
     _inputFieldSearch(event)

[Frances Cornwall]

Pull request: https://github.com/WebKit/WebKit/pull/16507

[EWS]

Committed 266783@main (6d291b6825cc): <https://commits.webkit.org/266783@main>

Reviewed commits have been landed. Closing PR #16507 and removing active labels.

[Radar WebKit Bug Importer]

<rdar://problem/113714342>

[Alexey Proskuryakov]

*** Bug 260545 has been marked as a duplicate of this bug. ***