Bug 259793 - Detect UA transitions on same-document navigations
Summary: Detect UA transitions on same-document navigations
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: History (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Rob Buis
URL:
Keywords: InRadar
Depends on: 264730
Blocks: 264748
  Show dependency tree / graph
 
Reported: 2023-08-03 12:59 PDT by khush
Modified: 2024-03-29 07:19 PDT (History)
5 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description khush 2023-08-03 12:59:29 PDT 
Tracking bug to implement https://github.com/whatwg/html/issues/8782.
Comment 1 Radar WebKit Bug Importer 2023-08-10 13:00:14 PDT 
<rdar://problem/113709539>
Comment 2 Rob Buis 2023-10-06 02:24:54 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/18756
Comment 3 EWS 2023-11-11 02:02:33 PST 
Committed 270589@main (f034bb9b9246): <https://commits.webkit.org/270589@main>

Reviewed commits have been landed. Closing PR #18756 and removing active labels.
Comment 4 khush 2023-11-13 09:03:23 PST 
The value for hasUAVisualTransition should be true if the browser does an animation from a user swipe when navigating. I don't think that was done in the PR linked below.
Comment 5 Rob Buis 2023-11-13 09:07:57 PST 
(In reply to khush from comment #4)
> The value for hasUAVisualTransition should be true if the browser does an
> animation from a user swipe when navigating. I don't think that was done in
> the PR linked below.

You are right, more work is needed. Note though that the default behaviour of github merge-queue logic lands the PR and closes the associated bug, which is what happened here.
Comment 6 Anne van Kesteren 2023-11-13 10:51:32 PST 
Let's leave this as fixed to keep Bugzilla/Radar/GitHub in sync.

Bug 264730 will put this behind a flag so it's not shipped in this state.

Bug 264748 tracks macOS/iOS implementation. Once those are in place this can be reconsidered for enablement.
Comment 7 Anne van Kesteren 2024-03-29 07:19:21 PDT 
I've put up bug 271886 for enabling this by default.