Bug 25977 - build-launcher-dmg depends on drosera
Summary: build-launcher-dmg depends on drosera
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-05-23 01:54 PDT by Eric Seidel (no email)
Modified: 2009-05-23 05:45 PDT (History)
1 user (show)

See Also:


Attachments
fix build-launcher to run w/o drosera (1.91 KB, patch)
2009-05-23 01:54 PDT, Eric Seidel (no email)
mrowe: review-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2009-05-23 01:54:04 PDT
build-launcher-dmg depends on drosera

It shouldn't.  Drosera is long dead.

        I use this script to build launchable dmgs which I can pass
        to other teams in Google to verify fixes before sending the
        fixes out for patch review.  It broke a while back and I've
        been meaning to post a fix.  Finally doing so.

Mark didn't sound very keen on me fixing this script.  But I'm posting this anyway so it's off my harddrive.
Comment 1 Eric Seidel (no email) 2009-05-23 01:54:39 PDT
Created attachment 30613 [details]
fix build-launcher to run w/o drosera

 2 files changed, 14 insertions(+), 5 deletions(-)
Comment 2 Mark Rowe (bdash) 2009-05-23 02:24:58 PDT
Comment on attachment 30613 [details]
fix build-launcher to run w/o drosera

As I mentioned on IRC, I'd prefer that you not land this at the moment as I intend to replace this script, and others that are part of the nightly build process, with my current versions in the near future.  Making changes to it in the mean time will just make my merging for nightly builds more painful.  The script has been broken for over a year already, so I don't think a few more weeks will hurt.
Comment 3 Eric Seidel (no email) 2009-05-23 05:45:39 PDT
Yup, no problem.