Bug 25974 - [V8] Enable timers in Chromium workers
Summary: [V8] Enable timers in Chromium workers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-05-22 18:26 PDT by Dmitry Titov
Modified: 2009-05-27 15:17 PDT (History)
2 users (show)

See Also:


Attachments
Proposed patch (7.60 KB, patch)
2009-05-22 18:50 PDT, Dmitry Titov
dglazkov: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Titov 2009-05-22 18:26:06 PDT
Updated V8 versions of ScheduledAction and WorkerContextCustom to actually invoke timers from workers in Chromium.
Comment 1 Dmitry Titov 2009-05-22 18:50:42 PDT
Created attachment 30602 [details]
Proposed patch
Comment 2 Dimitri Glazkov (Google) 2009-05-25 10:30:48 PDT
Comment on attachment 30602 [details]
Proposed patch

Fine to land after addressing these style nits.

> +    } else {
> +        scriptController->evaluate(m_code);
> +    }

No braces here?

> +    v8::Handle<v8::Value> function = args[0];
> +	int32_t timeout = argumentCount >= 2 ? args[1]->Int32Value() : 0;

Weird spacing thing?
Comment 3 Dmitry Titov 2009-05-26 14:51:22 PDT
Fixed according to Dimitri's comments and landed: http://trac.webkit.org/changeset/44160
Comment 4 Dimitri Glazkov (Google) 2009-05-27 15:17:01 PDT
Chromium fix landed as http://trac.webkit.org/changeset/44202. I should've picked this up during review :-\.