Bug 25971 - Some Video Elements Creeping Into Non-Video Builds
Summary: Some Video Elements Creeping Into Non-Video Builds
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords: Regression
Depends on:
Blocks:
 
Reported: 2009-05-22 16:27 PDT by Brent Fulgham
Modified: 2009-05-24 18:42 PDT (History)
0 users

See Also:


Attachments
Correct a few build errors. (7.95 KB, patch)
2009-05-22 17:45 PDT, Brent Fulgham
aroben: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2009-05-22 16:27:01 PDT
The Windows Cairo variant fails to build at the moment because a few media
controller files are getting included in the standard build.  The attached patch corrects this problem for users who disabled the VIDEO build option.
Comment 1 Brent Fulgham 2009-05-22 17:45:47 PDT
Created attachment 30598 [details]
Correct a few build errors.
Comment 2 Adam Roben (:aroben) 2009-05-22 17:47:20 PDT
Comment on attachment 30598 [details]
Correct a few build errors.

> +++ WebCore/rendering/RenderThemeWin.cpp	(working copy)
> @@ -28,7 +28,9 @@
>  #include "HTMLElement.h"
>  #include "HTMLSelectElement.h"
>  #include "Icon.h"
> +#if ENABLE(VIDEO)
>  #include "RenderMediaControls.h"
> +#endif
>  #include "RenderSlider.h"
>  #include "Settings.h"
>  #include "SoftLinking.h"

Please move conditional includes into their own paragraphs below unconditional includes before landing.

r=me
Comment 3 Brent Fulgham 2009-05-24 18:42:00 PDT
Landed previously.