Bug 259631 - Out-of-flow <br> should not trigger a line break
Summary: Out-of-flow <br> should not trigger a line break
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-07-29 15:57 PDT by zalan
Modified: 2023-08-01 08:24 PDT (History)
15 users (show)

See Also:

Attachments
Patch (14.79 KB, patch)
2023-07-29 16:24 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (23.60 KB, patch)
2023-07-29 21:40 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (7.19 KB, patch)
2023-07-30 21:09 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 zalan 2023-07-29 16:24:02 PDT 
Created attachment 467157 [details]
Patch
Comment 2 Tim Nguyen (:ntim) 2023-07-29 21:32:20 PDT 
Comment on attachment 467157 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=467157&action=review

> LayoutTests/fast/inline/out-of-flow-forced-line-break.html:1
> +<style>

Would be a really good WPT especially if browsers disagree here.
Comment 3 zalan 2023-07-29 21:40:22 PDT 
Created attachment 467158 [details]
Patch
Comment 4 zalan 2023-07-30 21:09:11 PDT 
Created attachment 467159 [details]
Patch
Comment 5 zalan 2023-08-01 07:28:58 PDT 
alternatively we could just create a generic RenderBox for such out-of-flow line breaks so that we don't have to promote RenderLineBreak to a RenderBox subclass.
Comment 6 zalan 2023-08-01 07:29:36 PDT 
(though most of this patch would still be needed)
Comment 7 zalan 2023-08-01 07:31:08 PDT 
(In reply to Tim Nguyen (:ntim) from comment #2)
> Comment on attachment 467157 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=467157&action=review
> 
> > LayoutTests/fast/inline/out-of-flow-forced-line-break.html:1
> > +<style>
> 
> Would be a really good WPT especially if browsers disagree here.
agree. we would still fail slightly more involved WPT tests though.
Comment 8 EWS 2023-08-01 08:23:20 PDT 
Committed 266475@main (f71ea9e98639): <https://commits.webkit.org/266475@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 467159 [details].
Comment 9 Radar WebKit Bug Importer 2023-08-01 08:24:19 PDT 
<rdar://problem/113208050>