Bug 25962 - wx port lacks triple click selection
: wx port lacks triple click selection
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: WebKit wx
: 528+ (Nightly build)
: PC All
: P2 Minor
Assigned To: Adam Barth
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-05-22 07:17 PDT by Kevin Watters
Modified: 2009-06-01 23:53 PDT (History)
0 users

See Also:


Attachments
use a timer to catch triple clicks and create PlatformMouseEvents accordingly (6.31 KB, patch)
2009-05-22 07:17 PDT, Kevin Watters
kevino: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin Watters 2009-05-22 07:17:15 PDT
The wx port is not creating PlatformMouseEvents with click counts of 3, so it lacks triple click paragraph selection.
Comment 1 Kevin Watters 2009-05-22 07:17:47 PDT
Created attachment 30580 [details]
use a timer to catch triple clicks and create PlatformMouseEvents accordingly
Comment 2 Eric Seidel 2009-05-22 07:25:31 PDT
Comment on attachment 30580 [details]
use a timer to catch triple clicks and create PlatformMouseEvents accordingly

Looks sane enough.

Where is the test case?  I assume Wx doesn't support DRT eventSender yet?  Otherwise you should be able to easily write a test which tests this.

r- for the lack of test case (or lack of ChangeLog explanation for why there isn't one).  If it's not possible to test this yet, please file a bug about adding support to Wx's DumpRenderTree.

Otherwise the patch looks fine and I would r+ it (or anyone else should feel free to) with the updated ChangeLog or test case.
Comment 3 Kevin Ollivier 2009-05-22 13:20:17 PDT
r+ from me. I've filed a meta bug on wx's DRT (https://bugs.webkit.org/show_bug.cgi?id=25967), and I really think that's all that's needed for now.
Comment 4 Adam Barth 2009-06-01 23:49:58 PDT
Will land.
Comment 5 Adam Barth 2009-06-01 23:53:12 PDT
This appears to already have been committed.