Bug 25962 - wx port lacks triple click selection
: wx port lacks triple click selection
Status: RESOLVED FIXED
: WebKit
WebKit wx
: 528+ (Nightly build)
: PC All
: P2 Minor
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2009-05-22 07:17 PST by
Modified: 2009-06-01 23:53 PST (History)


Attachments
use a timer to catch triple clicks and create PlatformMouseEvents accordingly (6.31 KB, patch)
2009-05-22 07:17 PST, Kevin Watters
kevino: review+
Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2009-05-22 07:17:15 PST
The wx port is not creating PlatformMouseEvents with click counts of 3, so it lacks triple click paragraph selection.
------- Comment #1 From 2009-05-22 07:17:47 PST -------
Created an attachment (id=30580) [details]
use a timer to catch triple clicks and create PlatformMouseEvents accordingly
------- Comment #2 From 2009-05-22 07:25:31 PST -------
(From update of attachment 30580 [details])
Looks sane enough.

Where is the test case?  I assume Wx doesn't support DRT eventSender yet?  Otherwise you should be able to easily write a test which tests this.

r- for the lack of test case (or lack of ChangeLog explanation for why there isn't one).  If it's not possible to test this yet, please file a bug about adding support to Wx's DumpRenderTree.

Otherwise the patch looks fine and I would r+ it (or anyone else should feel free to) with the updated ChangeLog or test case.
------- Comment #3 From 2009-05-22 13:20:17 PST -------
r+ from me. I've filed a meta bug on wx's DRT (https://bugs.webkit.org/show_bug.cgi?id=25967), and I really think that's all that's needed for now.
------- Comment #4 From 2009-06-01 23:49:58 PST -------
Will land.
------- Comment #5 From 2009-06-01 23:53:12 PST -------
This appears to already have been committed.