Bug 259578 – Add TraceScope to capture layout-ey activities only

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[zalan]

ssia

[zalan]

Created attachment 467137 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 467137 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=467137&action=review

> Source/WebCore/page/LocalFrameViewLayoutContext.cpp:246
> +        TraceScope tracingScope(LayoutStart, LayoutEnd);

This no longer includes InViewSizeAdjust or InPostLayout, which don't have their own trace point coverage. This will make it harder to see how much tine they are taking for forced layouts.

[zalan]

(In reply to Simon Fraser (smfr) from comment #2)
> Comment on attachment 467137 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=467137&action=review
> 
> > Source/WebCore/page/LocalFrameViewLayoutContext.cpp:246
> > +        TraceScope tracingScope(LayoutStart, LayoutEnd);
> 
> This no longer includes InViewSizeAdjust or InPostLayout, which don't have
> their own trace point coverage. This will make it harder to see how much
> tine they are taking for forced layouts.

sure but they are not layout either. do you want me to add new trace scopes?

[zalan]

(In reply to zalan from comment #3)
> (In reply to Simon Fraser (smfr) from comment #2)
> > Comment on attachment 467137 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=467137&action=review
> > 
> > > Source/WebCore/page/LocalFrameViewLayoutContext.cpp:246
> > > +        TraceScope tracingScope(LayoutStart, LayoutEnd);
> > 
> > This no longer includes InViewSizeAdjust or InPostLayout, which don't have
> > their own trace point coverage. This will make it harder to see how much
> > tine they are taking for forced layouts.
> 
> sure but they are not layout either. do you want me to add new trace scopes?
also don't we just re-enter LocalFrameViewLayoutContext::performLayout?

[zalan]

Created attachment 467138 [details]
Patch

[zalan]

Created attachment 467139 [details]
Patch

[zalan]

Created attachment 467140 [details]
Patch

[EWS]

Committed 266372@main (703501c4541f): <https://commits.webkit.org/266372@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 467140 [details].

[Radar WebKit Bug Importer]

<rdar://problem/113006480>