WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
259562
REGRESSION(
219104@main
): Broke --analyze and --coverage flags of build-jsc/build-webgpu
https://bugs.webkit.org/show_bug.cgi?id=259562
Summary
REGRESSION(219104@main): Broke --analyze and --coverage flags of build-jsc/bu...
Michael Catanzaro
Reported
2023-07-27 08:37:55 PDT
It looks like
219104@main
"build-jsc should invoke make instead of calling xcodebuild directly" broke the --analyze and --coverage options of build-jsc for Apple ports (and nowadays also build-webgpu since this code was moved from build-jsc to BuildSubproject.pm). (These options never worked for CMake ports.) When the flags are used, then additional XCode build options get added to @additionalSupportOptions, but this variable is no longer used anywhere. I don't know how to fix it. Maybe the flags are not too valuable, since it took three years for us to notice, and I only noticed while trying to fix an unrelated bug (
bug #259527
). We should consider removing the flags. If we fix the flags instead of removing them, consider adjusting the help output to indicate they only work with XCode and not CMake.
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2023-08-03 08:38:16 PDT
<
rdar://problem/113337079
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug