Bug 25955 - Clean up messy third-party cookie blocking code
Summary: Clean up messy third-party cookie blocking code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-05-22 00:06 PDT by Adam Barth
Modified: 2009-05-22 10:35 PDT (History)
2 users (show)

See Also:


Attachments
Step 1: Unify names (18.60 KB, patch)
2009-05-22 00:13 PDT, Adam Barth
mjs: review+
Details | Formatted Diff | Diff
Step 2: Remove bug-bait parameter (7.78 KB, patch)
2009-05-22 00:13 PDT, Adam Barth
mjs: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2009-05-22 00:06:00 PDT
Our code for computing the first-party context for third-party cookie blocking is seriously messy.  We have at least two names for the same context (policyBaseURL and mainDocumentURL).  The name mainDocumentURL is particularly bad because it's occasionally a lie.  Anyway, I'm working on a patch stream to clean this up.
Comment 1 Adam Barth 2009-05-22 00:13:08 PDT
Created attachment 30574 [details]
Step 1: Unify names

I'll add a ChangeLog before landing.  ChangeLog + git = pain.
Comment 2 Adam Barth 2009-05-22 00:13:52 PDT
Created attachment 30575 [details]
Step 2: Remove bug-bait parameter

Again, I'll add a ChangeLog before landing.
Comment 3 Adam Barth 2009-05-22 00:14:47 PDT
I have some more ideas for cleaning this up further, but it's bed time for me.
Comment 4 Maciej Stachowiak 2009-05-22 00:32:07 PDT
Comment on attachment 30574 [details]
Step 1: Unify names

r=me
Comment 5 Maciej Stachowiak 2009-05-22 00:33:13 PDT
Comment on attachment 30575 [details]
Step 2: Remove bug-bait parameter

r=me
Comment 6 David Kilzer (:ddkilzer) 2009-05-22 06:19:07 PDT
(In reply to comment #1)
> I'll add a ChangeLog before landing.  ChangeLog + git = pain.

ChangeLog +git +  resolve-ChangeLogs = less pain
Comment 7 Adam Barth 2009-05-22 09:10:42 PDT
> ChangeLog +git +  resolve-ChangeLogs = less pain

Yeah, I tried that.  Maybe I was doing it wrong, but resolve-ChangeLogs screwed up the ChangeLog royally.
Comment 8 Adam Barth 2009-05-22 10:35:24 PDT
Fixed in r44047 and r44048.  There is more cleaning we can do, but we can work on that in another bug.