Bug 25955 – Clean up messy third-party cookie blocking code

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Adam Barth]

Our code for computing the first-party context for third-party cookie blocking is seriously messy.  We have at least two names for the same context (policyBaseURL and mainDocumentURL).  The name mainDocumentURL is particularly bad because it's occasionally a lie.  Anyway, I'm working on a patch stream to clean this up.

[Adam Barth]

Created attachment 30574 [details]
Step 1: Unify names

I'll add a ChangeLog before landing.  ChangeLog + git = pain.

[Adam Barth]

Created attachment 30575 [details]
Step 2: Remove bug-bait parameter

Again, I'll add a ChangeLog before landing.

[Adam Barth]

I have some more ideas for cleaning this up further, but it's bed time for me.

[Maciej Stachowiak]

Comment on attachment 30574 [details]
Step 1: Unify names

r=me

[Maciej Stachowiak]

Comment on attachment 30575 [details]
Step 2: Remove bug-bait parameter

r=me

[David Kilzer (:ddkilzer)]

(In reply to comment #1)
> I'll add a ChangeLog before landing.  ChangeLog + git = pain.

ChangeLog +git +  resolve-ChangeLogs = less pain

[Adam Barth]

> ChangeLog +git +  resolve-ChangeLogs = less pain

Yeah, I tried that.  Maybe I was doing it wrong, but resolve-ChangeLogs screwed up the ChangeLog royally.

[Adam Barth]

Fixed in r44047 and r44048.  There is more cleaning we can do, but we can work on that in another bug.