Our code for computing the first-party context for third-party cookie blocking is seriously messy. We have at least two names for the same context (policyBaseURL and mainDocumentURL). The name mainDocumentURL is particularly bad because it's occasionally a lie. Anyway, I'm working on a patch stream to clean this up.
Created attachment 30574 [details] Step 1: Unify names I'll add a ChangeLog before landing. ChangeLog + git = pain.
Created attachment 30575 [details] Step 2: Remove bug-bait parameter Again, I'll add a ChangeLog before landing.
I have some more ideas for cleaning this up further, but it's bed time for me.
Comment on attachment 30574 [details] Step 1: Unify names r=me
Comment on attachment 30575 [details] Step 2: Remove bug-bait parameter r=me
(In reply to comment #1) > I'll add a ChangeLog before landing. ChangeLog + git = pain. ChangeLog +git + resolve-ChangeLogs = less pain
> ChangeLog +git + resolve-ChangeLogs = less pain Yeah, I tried that. Maybe I was doing it wrong, but resolve-ChangeLogs screwed up the ChangeLog royally.
Fixed in r44047 and r44048. There is more cleaning we can do, but we can work on that in another bug.