Bug 25950 – JavaScriptCore Fails to Build on Windows (Cairo)

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore JavaScript

[Brent Fulgham]

The recent (great!) change to using more Visual Studio property sheets introduced a build error for the non-Apple build of JavaScriptCore.  The Cairo version links against CFLite.dll, rather than CoreFoundation (as this is not redistributable).

Unfortunately, the JavaScriptCoreCommon.vsprops file assumes full CoreFoundation support.

Suggestion:
Create two new property sheets, and modify the projects to make use of them:
(1) JavaScriptCoreCF.vsprops, which uses the true CoreFoundation library.
(2) JavaScriptCoreCFLite.vsprops, which uses the open source CFLite library.

All current targets in the JavaScriptCore project will now also inherit from JavaScriptCoreCF.vsprops, and should be unaffected.

Create two new project targets (Debug_Cairo and Release_Cairo), that will be identical to the standard Debug and Release, but will inherit from JavaScriptCoreCFLite.vsprops instead of JavaScriptCoreCF.vsprops.

[Brent Fulgham]

Created attachment 30589 [details]
Patch to allow redistributable JavaScriptCore Builds

[Steve Falkenburg]

Please consider using _CFLite as the suffix for the configs instead of Cairo, since JavaScriptCore has no Cairo dependencies.

[Brent Fulgham]

Created attachment 30592 [details]
Revised patch to use CFLite labels.

[Steve Falkenburg]

You need to use your name instead of "U-bfulgham-PC\bfulgham" in both ChangeLogs.
Config is still named Debug_Cairo/Release_Cairo. Please rename to Debug_CFLite/Release_CFLite.
Fix ChangeLog to refer to Debug_CFLite/Release_CFLite instead of _Cairo.

[Brent Fulgham]

Created attachment 30593 [details]
Correct my name, remove erroneous Debug_Cairo/Release_Cairo references.

Minor update to replace U-bfulgham-PC\bfulgham with Brent Fulgham, as well as correctly naming configurations.

[Brent Fulgham]

Landed in r44063.