RESOLVED FIXED 25946
Chromium needs MIMETypeRegistry::getMediaMIMETypeForExtension implementation.
https://bugs.webkit.org/show_bug.cgi?id=25946
Summary Chromium needs MIMETypeRegistry::getMediaMIMETypeForExtension implementation.
David Levin
Reported 2009-05-21 13:40:21 PDT
See summary.
Attachments
Proposed fix. (4.83 KB, patch)
2009-05-21 13:43 PDT, David Levin
no flags
Proposed fix. (1.42 KB, patch)
2009-05-21 14:06 PDT, David Levin
fishd: review+
David Levin
Comment 1 2009-05-21 13:43:28 PDT
Created attachment 30554 [details] Proposed fix.
David Levin
Comment 2 2009-05-21 14:06:43 PDT
Created attachment 30555 [details] Proposed fix.
Darin Fisher (:fishd, Google)
Comment 3 2009-05-21 14:11:38 PDT
Comment on attachment 30555 [details] Proposed fix. Looking at MediaPlayer.cpp, it really doesn't matter what we do here. In fact, the cost of getMIMETypeForExtension might not even be worth it. MediaPlayer only calls this function to take a guess at the mime type, which it then uses to help select the media player engine. Chromium only has one engine, so the guessed mime type is not interesting to us. R=me with either the current solution or just returning String() <-- i'd probably just return String().
David Levin
Comment 4 2009-05-21 14:20:46 PDT
Note You need to log in before you can comment on or make changes to this bug.