Bug 25946 - Chromium needs MIMETypeRegistry::getMediaMIMETypeForExtension implementation.
Summary: Chromium needs MIMETypeRegistry::getMediaMIMETypeForExtension implementation.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: David Levin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-05-21 13:40 PDT by David Levin
Modified: 2009-05-21 14:20 PDT (History)
1 user (show)

See Also:


Attachments
Proposed fix. (4.83 KB, patch)
2009-05-21 13:43 PDT, David Levin
no flags Details | Formatted Diff | Diff
Proposed fix. (1.42 KB, patch)
2009-05-21 14:06 PDT, David Levin
fishd: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Levin 2009-05-21 13:40:21 PDT
See summary.
Comment 1 David Levin 2009-05-21 13:43:28 PDT
Created attachment 30554 [details]
Proposed fix.
Comment 2 David Levin 2009-05-21 14:06:43 PDT
Created attachment 30555 [details]
Proposed fix.
Comment 3 Darin Fisher (:fishd, Google) 2009-05-21 14:11:38 PDT
Comment on attachment 30555 [details]
Proposed fix.

Looking at MediaPlayer.cpp, it really doesn't matter what we do here.  In fact, the cost of getMIMETypeForExtension might not even be worth it.  MediaPlayer only calls this function to take a guess at the mime type, which it then uses to help select the media player engine.  Chromium only has one engine, so the guessed mime type is not interesting to us.

R=me with either the current solution or just returning String() <-- i'd probably just return String().
Comment 4 David Levin 2009-05-21 14:20:46 PDT
http://trac.webkit.org/changeset/43981