Bug 25945 - Add support for MADV_FREE to TCMalloc
Summary: Add support for MADV_FREE to TCMalloc
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Cameron Zwarich (cpst)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2009-05-21 13:24 PDT by Cameron Zwarich (cpst)
Modified: 2009-05-21 15:13 PDT (History)
0 users

See Also:


Attachments
Proposed patch (2.47 KB, patch)
2009-05-21 13:36 PDT, Cameron Zwarich (cpst)
mrowe: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Cameron Zwarich (cpst) 2009-05-21 13:24:24 PDT
We should do this.
Comment 1 Cameron Zwarich (cpst) 2009-05-21 13:25:24 PDT
<rdar://problem/6910754>
Comment 2 Cameron Zwarich (cpst) 2009-05-21 13:36:40 PDT
Created attachment 30552 [details]
Proposed patch
Comment 3 Mark Rowe (bdash) 2009-05-21 13:39:52 PDT
Comment on attachment 30552 [details]
Proposed patch

r=me. A comment on why we prefer MADV_FREE over MADV_DONTNEED could be make the subtleties in this code a little less confusing.
Comment 4 Cameron Zwarich (cpst) 2009-05-21 15:13:25 PDT
Landed in r43988 with a comment explaining the change as per your suggestion.