Bug 259430 - Use a new type PathCloseSubpath instead of std::monostate to represent a close command in PathSegment
Summary: Use a new type PathCloseSubpath instead of std::monostate to represent a clos...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Cameron McCormack (:heycam)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-07-23 13:33 PDT by Cameron McCormack (:heycam)
Modified: 2023-07-24 14:01 PDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Cameron McCormack (:heycam) 2023-07-23 13:33:32 PDT 
Adding an empty struct lets us treat this command like all the others, and not special case it in the WTF::switchOn calls in PathSegment.cpp.
Comment 1 Radar WebKit Bug Importer 2023-07-23 13:33:49 PDT 
<rdar://problem/112741404>
Comment 2 Cameron McCormack (:heycam) 2023-07-23 13:37:14 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/16023
Comment 3 EWS 2023-07-24 14:00:58 PDT 
Committed 266264@main (fe314ea4b982): <https://commits.webkit.org/266264@main>

Reviewed commits have been landed. Closing PR #16023 and removing active labels.