Bug 259429 - Empty switch statements generated by opcode_generator.rb
Summary: Empty switch statements generated by opcode_generator.rb
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-07-23 13:27 PDT by Ian Grunert
Modified: 2023-07-24 18:29 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ian Grunert 2023-07-23 13:27:58 PDT 
AirOpcodeGenerated.h generates warnings when built with MSVC due to switch statements with no case clause (only default). This builds without warnings in clang but generates an extraneous jmp instruction to the next line.

Fix opcode_generator.rb to stop generating these empty switch statements.
Comment 1 Ian Grunert 2023-07-23 13:51:39 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/16024
Comment 2 EWS 2023-07-24 18:28:28 PDT 
Committed 266276@main (ca2d701ed884): <https://commits.webkit.org/266276@main>

Reviewed commits have been landed. Closing PR #16024 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2023-07-24 18:29:18 PDT 
<rdar://problem/112806830>