WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
259420
Handle focusability for plugin elements which has browsing context
https://bugs.webkit.org/show_bug.cgi?id=259420
Summary
Handle focusability for plugin elements which has browsing context
Ahmad Saleem
Reported
2023-07-22 14:22:53 PDT
Hi Team, I came across another failing test case from Blink's case: Blink:
https://chromium.googlesource.com/chromium/src.git/+/a2c82afad86cf4f85f91df76f858434b15fe6b13
I tried it locally with test case and we fail without patching and patch is just:
>> In Source/WebCore/html/HTMLPlugInElement.cpp:
bool HTMLPlugInElement::isKeyboardFocusable(KeyboardEvent* event) const { if (HTMLFrameOwnerElement::isKeyboardFocusable(event)) return true; return false; }
>> In Source/WebCore/html/HTMLFrameOwnerElement.h:
Move: bool isKeyboardFocusable(KeyboardEvent*) const override; from 'Private' to 'Public'. ________ Just wanted to raise so we can track and fix it. Thanks!
Attachments
Add attachment
proposed patch, testcase, etc.
EWS
Comment 1
2023-07-25 02:02:02 PDT
Committed
266286@main
(61a5480546df): <
https://commits.webkit.org/266286@main
> Reviewed commits have been landed. Closing PR #16041 and removing active labels.
Radar WebKit Bug Importer
Comment 2
2023-07-25 02:03:19 PDT
<
rdar://problem/112821601
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug