Bug 259409 - REGRESSION(266064@main): [ WK2 ] imported/w3c/web-platform-tests/cookies/partitioned-cookies/partitioned-cookies.tentative.https.html is a flaky TEXT failure
Summary: REGRESSION(266064@main): [ WK2 ] imported/w3c/web-platform-tests/cookies/part...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Sneddon [:gsnedders]
URL:
Keywords: InRadar
Depends on: 263024
Blocks:
  Show dependency treegraph
 
Reported: 2023-07-21 15:00 PDT by Ben Schwartz
Modified: 2023-10-18 12:27 PDT (History)
5 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ben Schwartz 2023-07-21 15:00:56 PDT
imported/w3c/web-platform-tests/cookies/partitioned-cookies/partitioned-cookies.tentative.https.html

This test is a flaky TEXT failure on WebKit 2.

HISTORY:

https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fcookies%2Fpartitioned-cookies%2Fpartitioned-cookies.tentative.https.html

TEXT DIFF:

-FAIL Partitioned cookies accessible on the top-level site they are created in via HTTP assert_equals: Expected __Host-pccookistore to be available on the top-level site it was created in expected true but got false
-FAIL Partitioned cookies accessible on the top-level site they are created in via DOM assert_equals: Expected __Host-pccookistore to be available on the top-level site it was created in expected true but got false
-FAIL Partitioned cookies accessible on the top-level site they are created in via CookieStore assert_equals: Expected __Host-pccookistore to be available on the top-level site it was created in expected true but got false
-PASS Cross-site window opened correctly
-FAIL Partitioned cookies are not accessible on a different top-level site via HTTP assert_equals: Expected __Host-pchttp to not be available on a different top-level site expected false but got true
-FAIL Partitioned cookies are not accessible on a different top-level site via DOM assert_equals: Expected __Host-pchttp to not be available on a different top-level site expected false but got true
-FAIL Partitioned cookies are not accessible on a different top-level site via CookieStore assert_equals: Expected __Host-pchttp to not be available on a different top-level site expected false but got true
-

DIFF URL:

https://build.webkit.org/results/Apple-iOS-16-Simulator-Release-WK2-Tests/266215@main%20(3543)/imported/w3c/web-platform-tests/cookies/partitioned-cookies/partitioned-cookies.tentative.https-pretty-diff.html
Comment 1 Radar WebKit Bug Importer 2023-07-21 15:01:08 PDT
<rdar://problem/112683033>
Comment 2 Ben Schwartz 2023-07-21 15:04:40 PDT
This test seems to have been a flaky failure since this 266067@main. There is a likely regression point between 266062@main and 266067@main.

Furthermore, I was able to reproduce this test failure at macOS Ventura Production ToT running the test as follows:

run-webkit-tests imported/w3c/web-platform-tests/cookies/partitioned-cookies/partitioned-cookies.tentative.https.html --verbose --iterations 10
Comment 3 EWS 2023-07-21 15:26:19 PDT
Committed 266221@main (fa077af2e594): <https://commits.webkit.org/266221@main>

Reviewed commits have been landed. Closing PR #16001 and removing active labels.
Comment 4 Ben Schwartz 2023-07-21 15:35:56 PDT
I was able to bisect a regression point. This test reproduced at 266064@main, but it did not reproduce at 266063@main. Changes at 266064@main are directly related to this error, and is likely what caused the failure.

https://commits.webkit.org/266064@main
Comment 5 Sam Sneddon [:gsnedders] 2023-10-13 04:28:31 PDT
Pull request: https://github.com/WebKit/WebKit/pull/19043
Comment 6 EWS 2023-10-18 12:27:30 PDT
Committed 269483@main (5273909547b1): <https://commits.webkit.org/269483@main>

Reviewed commits have been landed. Closing PR #19043 and removing active labels.