Bug 259281 - [webkitpy] Convert 3.6 import error to message
Summary: [webkitpy] Convert 3.6 import error to message
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-07-17 11:14 PDT by Jonathan Bedard
Modified: 2023-07-17 11:33 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2023-07-17 11:14:04 PDT 
We shouldn't pro-actively raise an import error when clients are using Python 3.6. It's true that many scripts won't support Python 3.6, but that isn't nessesarily true for webkitpy as a whole. In any case, for the scripts which this _is_ the case, we will end up with an import exception anyways. Convert this import error to a printed error message instead.
Comment 1 Radar WebKit Bug Importer 2023-07-17 11:14:17 PDT 
<rdar://problem/112415698>
Comment 2 Jonathan Bedard 2023-07-17 11:15:22 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/15886
Comment 3 EWS 2023-07-17 11:33:18 PDT 
Committed 266104@main (7e218f4ef9d6): <https://commits.webkit.org/266104@main>

Reviewed commits have been landed. Closing PR #15886 and removing active labels.