Bug 259246 - [contain-intrinsic-size] Use StyleBuilderConverter instead of StyleBuilderCustom
Summary: [contain-intrinsic-size] Use StyleBuilderConverter instead of StyleBuilderCustom
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-07-15 11:45 PDT by Tim Nguyen (:ntim)
Modified: 2023-07-28 09:48 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Nguyen (:ntim) 2023-07-15 11:45:19 PDT 
Mistakes like bug 259237 would be avoided if we used StyleBuilderConverter.

We'd need to store contain-intrinsic-size fields into a single struct instead of two separate RenderStyle items.
Comment 1 Radar WebKit Bug Importer 2023-07-22 11:46:16 PDT 
<rdar://problem/112713755>
Comment 2 Rob Buis 2023-07-28 09:48:14 PDT 
Tim, do you think this is still worth doing? I can give it a go, though I don't know if it would have fixed the inherit problem (I am not too familiar with StyleBuilderConverter)?