WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
Bug 25924
Windows DumpRenderTree needs multi-file Drag and Drop support (eventSender.beginDragWithFiles)
https://bugs.webkit.org/show_bug.cgi?id=25924
Summary
Windows DumpRenderTree needs multi-file Drag and Drop support (eventSender.be...
Eric Seidel (no email)
Reported
2009-05-21 03:57:50 PDT
Windows DumpRenderTree needs Drag and Drop support The LayoutTests/platform/win/Skipped list clearly shows that DnD is not currently functional on windows DRT: # Drag & Drop doesn't work correctly in DRT <
rdar://5621244
> editing/pasteboard/drag-image-in-about-blank-frame.html editing/pasteboard/get-data-text-plain-drop.html editing/selection/drag-in-iframe.html fast/events/drag-in-frames.html fast/events/standalone-image-drag-to-editable.html But it's very much needed to test things like
bug 25916
and
bug 25913
and
bug 25923
. The mac side of multi-file dragging was added in
bug 25852
. I'm hoping some of the Windows experts can help me understand what needs to be done here to fake this on Windows. I don't even see equivalent calls like [webview dragEntered:info] in the Windows DRT.
Attachments
Add attachment
proposed patch, testcase, etc.
Adam Roben (:aroben)
Comment 1
2009-05-21 09:43:28 PDT
(In reply to
comment #0
)
> Windows DumpRenderTree needs Drag and Drop support > > The LayoutTests/platform/win/Skipped list clearly shows that DnD is not > currently functional on windows DRT: > > # Drag & Drop doesn't work correctly in DRT <
rdar://5621244
> > editing/pasteboard/drag-image-in-about-blank-frame.html > editing/pasteboard/get-data-text-plain-drop.html > editing/selection/drag-in-iframe.html > fast/events/drag-in-frames.html > fast/events/standalone-image-drag-to-editable.html
It is partially functional. But it's buggy.
> I don't even see equivalent calls like [webview dragEntered:info] > in the Windows DRT.
<
http://trac.webkit.org/browser/trunk/WebKitTools/DumpRenderTree/win/EventSender.cpp?rev=43159#L191
>
Eric Seidel (no email)
Comment 2
2009-05-21 16:25:13 PDT
I would suspect a DragOver() call is also needed on eventSender.mouseMoveTo.
Adam Roben (:aroben)
Comment 3
2009-05-21 16:45:42 PDT
(In reply to
comment #2
)
> I would suspect a DragOver() call is also needed on eventSender.mouseMoveTo.
We already do that, too: <
http://trac.webkit.org/browser/trunk/WebKitTools/DumpRenderTree/win/EventSender.cpp?rev=43159#L229
>.
Eric Seidel (no email)
Comment 4
2009-05-21 16:47:12 PDT
I swear I searched for it on the page... honest. :)
Marshall Culpepper
Comment 5
2009-10-19 14:55:37 PDT
You guys have any more insight as to what's buggy about the current code in DRT? I might take a look at it so we can test win32 D&D functionality reliably..
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug