Bug 25918 - text inputs + margins causes wrapping in windows webkit
Summary: text inputs + margins causes wrapping in windows webkit
Status: RESOLVED WORKSFORME
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Nobody
URL: http://americanexpress.com/activate
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2009-05-21 01:37 PDT by Ojan Vafai
Modified: 2010-01-04 14:15 PST (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ojan Vafai 2009-05-21 01:37:52 PDT
After http://trac.webkit.org/changeset/43355, the three text inputs in the middle of the page wrap when they shouldn't in Windows WebKit. The problem is that we match IE widths for the inputs, but then have extra margins that cause the three inputs to not fit on the line.

There's a couple things we could do to fix this:
1. When we have intrinsic margins, make inputs/textareas correspondingly smaller.
2. Use the IE margins on inputs/textareas and live with them looking somewhat less pretty.
3. Always make inputs/textareas smaller by the fixed amount that we grow intrinsic margins by.
4. Live with the incompatibility and try to contact the americanexpress.com webmaster to fix their site.

It's not clear to me what the best choice here is.
Comment 1 mitz 2009-06-19 12:42:05 PDT
<rdar://problem/6989388>
Comment 2 Ojan Vafai 2010-01-04 14:15:53 PST
As best I can tell, this has been fixed on the americanexpress.com side. They've added CSS widths to the text inputs.