Bug 259160 - [ macOS iOS ] http/tests/privateClickMeasurement/triggering-event-with-attribution-source-through-fetch-keepalive.html is a flaky text failure
Summary: [ macOS iOS ] http/tests/privateClickMeasurement/triggering-event-with-attrib...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Charlie Wolfe
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-07-12 13:36 PDT by Robert Jenner
Modified: 2023-08-10 18:48 PDT (History)
5 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Jenner 2023-07-12 13:36:03 PDT
http/tests/privateClickMeasurement/triggering-event-with-attribution-source-through-fetch-keepalive.html

is a flaky text failure on macOs and iOS. It fails more frequently on Mac, than it does on iOS. But it does appear to be flaky on both. 

HISTORY:
https://results.webkit.org/?suite=layout-tests&test=http%2Ftests%2FprivateClickMeasurement%2Ftriggering-event-with-attribution-source-through-fetch-keepalive.html

TEXT DIFF:
+CONSOLE MESSAGE: Origin http://localhost:8000 is not allowed by Access-Control-Allow-Origin. Status code: 404
+CONSOLE MESSAGE: Fetch API cannot load https://localhost:8443/.well-known/private-click-measurement/trigger-attribution/12?attributionSource=https://127.0.0.1 due to access control checks.
+CONSOLE MESSAGE: Unhandled Promise Rejection: TypeError: Load failed
 CONSOLE MESSAGE: [Private Click Measurement] Triggering event was not accepted because the conversion data could not be parsed or was higher than the allowed maximum of 15.
 CONSOLE MESSAGE: Origin http://localhost:8000 is not allowed by Access-Control-Allow-Origin. Status code: 404
 CONSOLE MESSAGE: Fetch API cannot load https://localhost:8443/.well-known/private-click-measurement/trigger-attribution/Dummy?attributionSource=https://127.0.0.1 due to access control checks.


DIFF URL:
https://build.webkit.org/results/Apple-Monterey-Debug-WK2-Tests/265988@main%20(8187)/http/tests/privateClickMeasurement/triggering-event-with-attribution-source-through-fetch-keepalive-pretty-diff.html
Comment 1 Radar WebKit Bug Importer 2023-07-12 13:41:06 PDT
<rdar://problem/112155451>
Comment 2 EWS 2023-07-12 13:52:03 PDT
Test gardening commit 266005@main (6a50dd8d2c2e): <https://commits.webkit.org/266005@main>

Reviewed commits have been landed. Closing PR #15794 and removing active labels.
Comment 3 Robert Jenner 2023-07-12 13:54:59 PDT
Interestingly enough I also see it failing this way on Ventura:

TEXT DIFF:
 Tests triggering of private click measurement attribution with same-site triggering event request.
 
 
-Attributed Private Click Measurements:
+Unattributed Private Click Measurements:
 WebCore::PrivateClickMeasurement 1
 Source site: 127.0.0.1
 Attribute on site: localhost
 Source ID: 3
-Attribution trigger data: 12
-Attribution priority: 0
-Attribution earliest time to send: Within 24-48 hours
-Destination token: Not set
+No attribution trigger data.
 Application bundle identifier: testBundleID

DIFF URL:
https://build.webkit.org/results/Apple-Ventura-Release-AppleSilicon-WK2-Tests/265957@main%20(3970)/http/tests/privateClickMeasurement/triggering-event-with-attribution-source-through-fetch-keepalive-pretty-diff.html


And I was also able to trivially reproduce this failure at Ventura Release ToT running the test as follows:


run-webkit-tests http/tests/privateClickMeasurement/triggering-event-with-attribution-source-through-fetch-keepalive.html --iterations 100


It only reproduced 2 out of 100 times when I ran in iterations.
Comment 4 EWS 2023-07-12 14:44:07 PDT
Test gardening commit 265870.50@safari-7616-branch (081893a11bbe): <https://commits.webkit.org/265870.50@safari-7616-branch>

Reviewed commits have been landed. Closing PR #685 and removing active labels.
Comment 5 Ben Schwartz 2023-08-10 14:44:26 PDT
This test has the same diff log and similar history as the following test:

http/tests/privateClickMeasurement/triggering-event-with-attribution-source-through-fetch-keepalive-ephemeral.html

Marking new test expectations.
Comment 6 Ben Schwartz 2023-08-10 16:59:29 PDT
Upon further inspection, the issue persists across these three tests:

http/tests/privateClickMeasurement/triggering-event-with-attribution-source-through-fetch-keepalive.html
http/tests/privateClickMeasurement/triggering-event-with-attribution-source-through-fetch-keepalive-ephemeral.html
http/tests/privateClickMeasurement/attribution-conversion-through-fetch-keepalive.html
http/tests/privateClickMeasurement/attribution-conversion-through-image-redirect-ephemeral.html

Marking the appropriate test expectations for the three tests other than this one.
Comment 7 Ben Schwartz 2023-08-10 18:48:53 PDT
After further review, the two diffs Robert mentioned are likely two separate issues. I have decided to file a new bug for the tests I mentioned instead of modifying the test expectations under this bug.

New bug link: https://webkit.org/b/260052