Bug 259108 - WTF/wtf/threads/Signals.cpp lacks Windows implementation
Summary: WTF/wtf/threads/Signals.cpp lacks Windows implementation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hayashida Ryuichi
URL:
Keywords: InRadar
Depends on:
Blocks: 222315
  Show dependency tree / graph
 
Reported: 2023-07-11 06:40 PDT by Hayashida Ryuichi
Modified: 2023-08-15 15:14 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hayashida Ryuichi 2023-07-11 06:40:44 PDT 
Signal handlers implementation in WTF/wtf/threads/Signals.cpp assumes only Unix platforms (OS(UNIX) is enabled). Windows implementation is necessary to support signal handlers for Wasm implementation at JavaScriptCore/wasm/WasmFaultSignalHandler.cpp. Same interface as Unix platforms would be implemented with Windows signal API.

s://learn.microsoft.com/en-us/cpp/c-runtime-library/reference/signal
Comment 1 Radar WebKit Bug Importer 2023-07-18 06:41:21 PDT 
<rdar://problem/112467230>
Comment 2 Ian Grunert 2023-08-04 11:00:59 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/16396
Comment 3 EWS 2023-08-08 22:39:40 PDT 
Committed 266716@main (66b9bc907a2e): <https://commits.webkit.org/266716@main>

Reviewed commits have been landed. Closing PR #16396 and removing active labels.