RESOLVED FIXED 258920
[browserperfdash-benchmark] Allow to send benchmark data with the timestamp of the git checkout and use it on the bots 
https://bugs.webkit.org/show_bug.cgi?id=258920
Summary [browserperfdash-benchmark] Allow to send benchmark data with the timestamp o...
Carlos Alberto Lopez Perez
Reported 2023-07-06 04:52:59 PDT
Since 249031 we are running performance tests with multiple RPis in parallel. And there is a potential issue that can happen because there are several workers for each performance bot working in parallel. Bot1 starts testing commit 1234@main Bot2 starts testing commit 1245@main Bot2 ends before than Bot1 -> The data on the dashboard will appear as if commit 1245@main happened before than 1234@main because the dashboard doesn't use the browser_version (or commit revision) to sort the data. The dashboard sorts the data by the timestamp. And the runner (the bot) defaults to sends automatically a timestamp with the date of when it finish testing. To overcome this problem we can implement a way of sending the data with the timestamp of the checked_out git commit (HEAD). That way we can also re-run performance tests on old checkouts and the data will be sent to the server with the right timestamp. We don't really care about when the performance test was executed, in reality we should care about the commit date of the commit that we have built (that is the one checked out).
Attachments
Add attachment proposed patch, testcase, etc.
Carlos Alberto Lopez Perez
Comment 1 2023-07-06 05:03:37 PDT
Pull request: https://github.com/WebKit/WebKit/pull/15595
EWS
Comment 2 2023-07-06 05:27:51 PDT
Committed 265798@main (9204150b17ce): <https://commits.webkit.org/265798@main> Reviewed commits have been landed. Closing PR #15595 and removing active labels.
Radar WebKit Bug Importer
Comment 3 2023-07-06 05:28:16 PDT
<rdar://problem/111843615>
Note You need to log in before you can comment on or make changes to this bug.