Bug 25890 - Implement Network logging channel on Mac
Summary: Implement Network logging channel on Mac
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Enhancement
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-05-20 08:06 PDT by Alexey Proskuryakov
Modified: 2009-05-21 11:52 PDT (History)
1 user (show)

See Also:


Attachments
proposed patch (10.47 KB, patch)
2009-05-20 08:12 PDT, Alexey Proskuryakov
ddkilzer: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2009-05-20 08:06:41 PDT
Network logging is implemented in ResourceHandleCFNet, but not in ResourceHandleMac.
Comment 1 Alexey Proskuryakov 2009-05-20 08:12:26 PDT
Created attachment 30509 [details]
proposed patch
Comment 2 David Kilzer (:ddkilzer) 2009-05-21 10:35:57 PDT
Comment on attachment 30509 [details]
proposed patch

>-- (void)connection:(NSURLConnection *)unusedConnection didFailWithError:(NSError *)error
>+- (void)connection:(NSURLConnection *)connection didFailWithError:(NSError *)error
> {
>-    UNUSED_PARAM(unusedConnection);
>+    UNUSED_PARAM(connection);
>+
>+    LOG(Network, "Handle %p delegate connection:%p didFailWithError:%@", m_handle, connection, error);

Is NSError* converted to an NSString* implicitly here?

r=me
Comment 3 Darin Adler 2009-05-21 10:48:36 PDT
(In reply to comment #2)
> Is NSError* converted to an NSString* implicitly here?

%@ logs the description of the object. So it doesn't just work with strings.

The answer is effectively yes.
Comment 4 Alexey Proskuryakov 2009-05-21 11:52:54 PDT
Committed <http://trac.webkit.org/changeset/43974>.