WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
258827
Bug 258793
follow-up: Add test to exercise the null-decoder-with-NoError path in Connection::sendSyncMessage and StreamClientConnection::trySendSyncStream
https://bugs.webkit.org/show_bug.cgi?id=258827
Summary
Bug 258793 follow-up: Add test to exercise the null-decoder-with-NoError path...
Gerald Squelart
Reported
2023-07-03 14:55:31 PDT
Bug 258793
modified `Connection::sendSyncMessage` to handle a code path that could potential return a null `Decoder` pointer along with an `Error::NoError`, which could eventually lead callers (e.g.: `WebPaymentCoordinator::canMakePayments`) to attempt to read the value of an empty `std::optional`. Unless the real root cause is found that would remove this code path entirely, it would be good to add a proper test that exercises it.
Attachments
Add attachment
proposed patch, testcase, etc.
Gerald Squelart
Comment 1
2023-07-05 02:44:24 PDT
Bug 258861
added a couple of other similar fixes in StreamClientConnection::trySendSyncStream.
Radar WebKit Bug Importer
Comment 2
2023-07-10 14:56:41 PDT
<
rdar://problem/112040784
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug