RESOLVED FIXED 258767
[WPE] run-minibrowser: unit test test_browser_name_default_with_cog_built is failing 
https://bugs.webkit.org/show_bug.cgi?id=258767
Summary [WPE] run-minibrowser: unit test test_browser_name_default_with_cog_built is ...
Diego Pino
Reported 2023-07-01 06:52:54 PDT
Unit test test_browser_name_default_with_cog_built is producing the following error in the WPE-Release-Test bot: ``` [1057/2215] webkitpy.port.wpe_unittest.WPEPortTest.test_browser_name_default_with_cog_built failed: Traceback (most recent call last): File "/app/webkit/Tools/Scripts/webkitpy/port/wpe_unittest.py", line 94, in test_browser_name_default_with_cog_built self.assertEqual(port.browser_name(), "cog") AssertionError: 'minibrowser' != 'cog' - minibrowser + cog ``` The reason is that environment variable WPE_BROWSER is set to 'minibrowser' in that host. The test should evaluate `port.browser_name()` on an empty environment.
Attachments
Add attachment proposed patch, testcase, etc.
Diego Pino
Comment 1 2023-07-01 06:58:22 PDT
Pull request: https://github.com/webkit/webkit/pull/15478
EWS
Comment 2 2023-07-02 18:15:54 PDT
Committed 265700@main (de456d04c100): <https://commits.webkit.org/265700@main> Reviewed commits have been landed. Closing PR #15478 and removing active labels.
Radar WebKit Bug Importer
Comment 3 2023-07-02 18:16:17 PDT
<rdar://problem/111660311>
Note You need to log in before you can comment on or make changes to this bug.