RESOLVED FIXED258613
import-w3c-tests is deleting -expected.txt files of variant test files 
https://bugs.webkit.org/show_bug.cgi?id=258613
Summary import-w3c-tests is deleting -expected.txt files of variant test files
youenn fablet
Reported 2023-06-28 00:29:00 PDT
When reimporting webcodecs tests, I can see files like LayoutTests/imported/w3c/web-platform-tests/webcodecs/reconfiguring-encoder.https.any_h264_avc-expected.txt being removed while they should not. We might want to refine our deletion heuristic.
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2023-07-05 00:29:16 PDT
<rdar://problem/111770351>
Sam Sneddon [:gsnedders]
Comment 2 2023-08-03 07:35:22 PDT
This is webkitpy.w3c.test_importer.TestImporter.remove_dangling_expectations; compare/contrast the logic there with that of webkitpy.port.base.Port._expected_baselines_for_suffixes. Note that this runs unconditionally (i.e., even without --clean-dest-dir).
Sam Sneddon [:gsnedders]
Comment 3 2023-08-03 09:55:55 PDT
Pull request: https://github.com/WebKit/WebKit/pull/16348
EWS
Comment 4 2023-08-04 10:05:33 PDT
Committed 266588@main (d8e12ca3753d): <https://commits.webkit.org/266588@main> Reviewed commits have been landed. Closing PR #16348 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.