Bug 258604 - Generated IPC decoders check the decode success twice
Summary: Generated IPC decoders check the decode success twice
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kimmo Kinnunen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-06-27 22:49 PDT by Kimmo Kinnunen
Modified: 2023-07-03 06:35 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kimmo Kinnunen 2023-06-27 22:49:51 PDT 
Generated IPC decoders check the decode success twice
- Once by the type decoder function when checking for std::optional engagement
- Once by the IPC::Decoder when decoding the next value
Comment 1 Radar WebKit Bug Importer 2023-06-27 22:50:01 PDT 
<rdar://problem/111434133>
Comment 2 Kimmo Kinnunen 2023-06-27 23:06:47 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/15357
Comment 3 EWS 2023-07-03 06:35:01 PDT 
Committed 265717@main (6006aa6aa0f6): <https://commits.webkit.org/265717@main>

Reviewed commits have been landed. Closing PR #15357 and removing active labels.