WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
258528
Rename 'assert-selection.js' to 'assert_selection.js' due to reliance on exact script name
https://bugs.webkit.org/show_bug.cgi?id=258528
Summary
Rename 'assert-selection.js' to 'assert_selection.js' due to reliance on exac...
Ahmad Saleem
Reported
2023-06-26 13:22:22 PDT
Hi Team, It is very clear bug and it is to update test expectation, where we get error in test script:
https://github.com/WebKit/WebKit/blob/0ed9d940afc3aac44f07b5f0b68626972aeeb6c1/LayoutTests/editing/inserting/insert-space-expected.txt#L4
--> It shows error here: resources/assert-selection.js:939:30 If I look at code:
https://github.com/WebKit/WebKit/blob/0ed9d940afc3aac44f07b5f0b68626972aeeb6c1/LayoutTests/resources/assert-selection.js#L938
It relies on 'assert_selection.js' rather my name of 'assert-selection.js' (which I kept to make it consistent with WebKit test naming and scripts name. I think it would be difficult to maintain in future to make this 'script name' change always, so I will just make script name consistent. So it is easier to always use up-to-date script from Chromium. Just raising this bug for that purpose. Thanks!
Attachments
Add attachment
proposed patch, testcase, etc.
EWS
Comment 1
2023-06-26 16:09:52 PDT
Committed
265531@main
(d164f4ce0298): <
https://commits.webkit.org/265531@main
> Reviewed commits have been landed. Closing PR #15300 and removing active labels.
Radar WebKit Bug Importer
Comment 2
2023-06-26 16:10:21 PDT
<
rdar://problem/111354177
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug