WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
25849
Clipboard.* are in dom/ but ClipboardMac.* are in platform/
https://bugs.webkit.org/show_bug.cgi?id=25849
Summary
Clipboard.* are in dom/ but ClipboardMac.* are in platform/
Eric Seidel (no email)
Reported
2009-05-17 23:52:30 PDT
Clipboard.* are in dom/ but ClipboardMac.* are in platform/ I think this means that ClipboardMac.* should be moved out of platform/ This is confusing because I don't know if I'm allowed to use dom stuff in Clipboard classes.
Attachments
Add attachment
proposed patch, testcase, etc.
Darin Adler
Comment 1
2009-05-18 09:08:52 PDT
Yes, ClipboardMac should be moved to be next to Clipboard in a mac subdirectory. Unfortunately, Pasteboard also doesn't qualify to be in the platform directory. It probably needs to go into the editing directory.
Eric Seidel (no email)
Comment 2
2009-05-18 17:22:33 PDT
It sounds like Clipboard might need to be split? Into dom/DOMClipboard.* and platform/Clipboard.*, or is Pasteboard* already supposed to be the platform/clipboard* stuff and we just haven't factored things quite right?
Darin Adler
Comment 3
2009-05-18 17:34:46 PDT
(In reply to
comment #2
)
> It sounds like Clipboard might need to be split? Into dom/DOMClipboard.* and > platform/Clipboard.*, or is Pasteboard* already supposed to be the > platform/clipboard* stuff and we just haven't factored things quite right?
Yes. Clipboard is a DOM object and should stay as one. Pasteboard is an attempt at a platform abstraction for pasteboards/clipboards, but: 1) Clipboard doesn't try to us it! 2) It has reverse dependencies on the DOM and Frame anyway, so it's not a good platform layer citizen, and probably needs to go into the editing directory. Making Pasteboard a better abstraction that really can live entirely in the platform directory is a one future direction, but for now we can probably live with having it in the editing directory for now, and Clipboard can use it as much as possible. Maybe later we can find a lower-level part we can truly factor out so it can go in the platform directory.
Eric Seidel (no email)
Comment 4
2009-05-18 17:49:38 PDT
Thank you for the insight.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug