Bug 25845 - [Qt] Fix QtWebKit pkgconfig dependencies
Summary: [Qt] Fix QtWebKit pkgconfig dependencies
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-05-17 20:39 PDT by Laszlo Gombos
Modified: 2009-05-20 03:09 PDT (History)
0 users

See Also:

Attachments
Proposed fix (+ removed some dead code) (1.53 KB, patch)
2009-05-17 20:48 PDT, Laszlo Gombos 		staikos: review-
Details | Formatted Diff | Diff
Second try. (1.52 KB, patch)
2009-05-19 21:19 PDT, Laszlo Gombos 		staikos: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Laszlo Gombos 2009-05-17 20:39:02 PDT 
QtWebKit should not depend on QtDBus. In addition QtWebKit only depends on QtXML for Qt version < 4.4.
Comment 1 Laszlo Gombos 2009-05-17 20:48:29 PDT 
Created attachment 30434 [details]
Proposed fix (+ removed some dead code)
Comment 2 George Staikos 2009-05-19 20:25:14 PDT 
Comment on attachment 30434 [details]
Proposed fix (+ removed some dead code)

Better sort out which one you want..  The changelog says no QtXml if Qt < 4.4, the change says no QtXml if Qt >= 4.4.  I think you just need to fix the changelog.
Comment 3 Laszlo Gombos 2009-05-19 21:19:16 PDT 
Created attachment 30493 [details]
Second try.

Fix changelog.
Comment 4 Ariya Hidayat 2009-05-20 03:09:56 PDT 
Landed in r43898
http://trac.webkit.org/changeset/43898