Bug 258420 - [css-text-decor] Don't propagate decorations to inline-flex/inline-grid
Summary: [css-text-decor] Don't propagate decorations to inline-flex/inline-grid
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: BrowserCompat, InRadar, WPTImpact
: 249748 (view as bug list)
Depends on:
Blocks:
 
Reported: 2023-06-22 15:30 PDT by Ahmad Saleem
Modified: 2023-06-23 12:56 PDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ahmad Saleem 2023-06-22 15:30:42 PDT 
Hi Team,

This is similar to Blink's commit: https://chromium.googlesource.com/chromium/src/+/d5332b9f908cde010ee5b9650c35e41b8eb156bb

To update our propagate decorations code: https://github.com/WebKit/WebKit/blob/10426777cd74f54c3bb69db4c764ee0643b4fcda/Source/WebCore/style/StyleAdjuster.cpp#L185

and add remaining display types to make us progress two more WPT tests.

WPT Test Links: http://wpt.live/css/css-text-decor/text-decoration-propagation-02.html & http://wpt.live/css/css-text-decor/text-decoration-propagation-03.html

Just wanted to raise, so we can fix them.

Thanks!
Comment 1 Ahmad Saleem 2023-06-22 15:31:22 PDT 
NOTE - we don't have imported these tests.
Comment 2 EWS 2023-06-23 12:13:16 PDT 
Committed 265471@main (1c13b5adb5e3): <https://commits.webkit.org/265471@main>

Reviewed commits have been landed. Closing PR #15239 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2023-06-23 12:14:16 PDT 
<rdar://problem/111228920>
Comment 4 Ahmad Saleem 2023-06-23 12:56:58 PDT 
*** Bug 249748 has been marked as a duplicate of this bug. ***