Bug 258402 - [macOS] Support WebM files with no track ID
Summary: [macOS] Support WebM files with no track ID
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-06-22 08:23 PDT by Eric Carlson
Modified: 2023-07-03 08:36 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2023-06-22 08:23:58 PDT 
Support WebM files with no track ID
Comment 1 Eric Carlson 2023-06-22 08:24:11 PDT 
rdar://110455790
Comment 2 Eric Carlson 2023-06-22 08:39:34 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/15193
Comment 3 EWS 2023-06-22 13:42:03 PDT 
Committed 265425@main (b9047adba096): <https://commits.webkit.org/265425@main>

Reviewed commits have been landed. Closing PR #15193 and removing active labels.
Comment 4 Thomas Wisniewski [:twisniewski] 2023-06-30 06:03:54 PDT 
Could we get a rationale for why doing this is a good idea? Are there sites where this is causing Safari and Firefox to not play videos where Chromium plays them, for instance? Because to my untrained eye, this makes it sound like Safari is now going to play invalid webm files, while other browsers will not (at least I don't think Firefox will play them).
Comment 5 Eric Carlson 2023-07-03 08:36:40 PDT 
The previous code would assert and crash when WebKit loaded a WebM file containing a track with no ID. We recently got hundreds of crash reports with this signature from many different devices. The crash reports are anonymized and do not contain any urls, so while we weren't able to identify the site to test it, given the frequency and number of crash reports we assume this kind of invalid webm files is supported in (an) other browser(s).