In ResourceResponseCurl, the reason-phrase of the HTTP status line is obtained in the ResourceResponse::setStatusLine function, but in order to reduce the code to be maintained, replace it with extractReasonPhraseFromHTTPStatusLine of HTTPParsers. Additionally, the reason-phrase can contain ":". Therefore, there is a possibility that the reason-phrase cannot be obtained with the current processing. (for example: HTTP/1.1 999 ABC:DEF) https://github.com/WebKit/WebKit/blob/e45a46fae1a59709b4d5dd5c043352129364d150/Source/WebCore/platform/network/curl/ResourceResponseCurl.cpp#L117-L129 --- auto splitPosition = header.find(':'); if (splitPosition != notFound) { ... } else if (startsWithLettersIgnoringASCIICase(header, "http"_s)) { // This is the first line of the response. setStatusLine(header); } ---
Pull request: https://github.com/WebKit/WebKit/pull/15180
Committed 265395@main (007a3ea80d5c): <https://commits.webkit.org/265395@main> Reviewed commits have been landed. Closing PR #15180 and removing active labels.
<rdar://problem/111142631>
Some tests regresses. Could you take a look? Buildbot: builder WinCairo-64-bit-Release-Tests build 1327 (265396@main) https://build.webkit.org/#/builders/728/builds/1327 Regressions: Unexpected text-only failures (9) http/tests/inspector/network/resource-redirect-request-headers.html [ Failure ] http/tests/xmlhttprequest/extra-parameters.html [ Failure ] http/tests/xmlhttprequest/response-special-characters.html [ Failure ] http/tests/xmlhttprequest/status-after-abort.html [ Failure ] http/tests/xmlhttprequest/web-apps/012.html [ Failure ] http/tests/xmlhttprequest/web-apps/013.html [ Failure ] http/tests/xmlhttprequest/xmlhttprequest-missing-file-exception.html [ Failure ] http/tests/xmlhttprequest/zero-length-response-sync.html [ Failure ] http/tests/xmlhttprequest/zero-length-response.html [ Failure ]
(In reply to Fujii Hironori from comment #4) > Some tests regresses. Could you take a look? > Sure.
https://bugs.webkit.org/show_bug.cgi?id=258442