Bug 258381 - [Xcode] migrate-headers.py matches path filters too permissively
Summary: [Xcode] migrate-headers.py matches path filters too permissively
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Elliott Williams
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-06-21 18:10 PDT by Elliott Williams
Modified: 2023-06-22 10:56 PDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Elliott Williams 2023-06-21 18:10:46 PDT
Xcode's path filtering considers the number of path components in a pattern, whereas the script just uses fnmatch.
Comment 1 Elliott Williams 2023-06-21 18:10:52 PDT
<rdar://problem/110926809>
Comment 2 Elliott Williams 2023-06-21 18:21:05 PDT
Pull request: https://github.com/WebKit/WebKit/pull/15173
Comment 3 EWS 2023-06-22 10:56:04 PDT
Committed 265412@main (862e1af4e3a7): <https://commits.webkit.org/265412@main>

Reviewed commits have been landed. Closing PR #15173 and removing active labels.