Bug 258314 - AX: AccessibilityNodeObject::addChildren() does not null-check its node before using it
Summary: AX: AccessibilityNodeObject::addChildren() does not null-check its node befor...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tyler Wilcock
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-06-20 12:21 PDT by Tyler Wilcock
Modified: 2023-06-20 18:18 PDT (History)
10 users (show)

See Also:

Attachments
Patch (1.21 KB, patch)
2023-06-20 12:25 PDT, Tyler Wilcock 		no flags Details | Formatted Diff | Diff
Patch (1.70 KB, patch)
2023-06-20 13:24 PDT, Tyler Wilcock 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tyler Wilcock 2023-06-20 12:21:30 PDT 
This leads to crashes.
Comment 1 Radar WebKit Bug Importer 2023-06-20 12:21:44 PDT 
<rdar://problem/111056760>
Comment 2 Tyler Wilcock 2023-06-20 12:22:28 PDT 
rdar://110703896
Comment 3 Tyler Wilcock 2023-06-20 12:25:39 PDT 
Created attachment 466765 [details]
Patch
Comment 4 chris fleizach 2023-06-20 12:38:05 PDT 
Comment on attachment 466765 [details]
Patch

should we put this in a local variable instead of calling node() 3 times?
Comment 5 Tyler Wilcock 2023-06-20 13:24:37 PDT 
Created attachment 466766 [details]
Patch
Comment 6 Tyler Wilcock 2023-06-20 13:24:51 PDT 
(In reply to chris fleizach from comment #4)
> Comment on attachment 466765 [details]
> Patch
> 
> should we put this in a local variable instead of calling node() 3 times?
Fixed!
Comment 7 EWS 2023-06-20 18:18:29 PDT 
Committed 265342@main (7c8d3655b4cb): <https://commits.webkit.org/265342@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 466766 [details].