WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
258313
WebPageProxy::setToolTip accesses a null PageClient
https://bugs.webkit.org/show_bug.cgi?id=258313
Summary
WebPageProxy::setToolTip accesses a null PageClient
Abrar Rahman Protyasha
Reported
2023-06-20 12:04:21 PDT
In
264455@main
, we introduced `WebPageProxy::dispatchMouseDidMoveOverElementAsynchronously`, which asks to perform `WebPageProxy::mouseDidMoveOverElement` at a future time. It turns out there's a null access on `m_pageClient` when we then call into `WebPageProxy::setToolTip`, which happens because we hold a `WeakPtr<PageClient>` instance to the `PageClient` object, meaning there are no guarantees on the PageClient instance's lifetime. We should make sure this null deference does not happen.
Attachments
Add attachment
proposed patch, testcase, etc.
Abrar Rahman Protyasha
Comment 1
2023-06-20 12:04:26 PDT
rdar://110501313
Abrar Rahman Protyasha
Comment 2
2023-06-20 12:08:18 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/15113
EWS
Comment 3
2023-06-23 03:28:58 PDT
Committed
265456@main
(46b03afa5a23): <
https://commits.webkit.org/265456@main
> Reviewed commits have been landed. Closing PR #15113 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug