Bug 258290 - REGRESSION(262797@main): Menu permanently opened on github.com
Summary: REGRESSION(262797@main): Menu permanently opened on github.com
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: PC Linux
: P2 Normal
Assignee: Carlos Garcia Campos
URL:
Keywords:
: 258306 (view as bug list)
Depends on:
Blocks:
 
Reported: 2023-06-19 19:04 PDT by Kdwk
Modified: 2023-08-02 06:14 PDT (History)
7 users (show)

See Also:

Attachments
Screenshot of menu being open on github.com (43.48 KB, image/png)
2023-06-19 19:04 PDT, Kdwk 		no flags Details
Screencast showing how to work around the problem (1.30 MB, video/webm)
2023-07-22 07:22 PDT, Kdwk 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kdwk 2023-06-19 19:04:27 PDT 
Created attachment 466762 [details]
Screenshot of menu being open on github.com

1. Visit github.com/WebKit/WebKit/pulls
2. Menu is permanently opened
Comment 1 Michael Catanzaro 2023-06-20 06:27:16 PDT 
It seems you see a different version of github.com than I do. I don't have any of those buttons.
Comment 2 Kdwk 2023-06-20 06:43:48 PDT 
You might want to try to fully reload the website by clicking on the URL bar and pressing Enter. GitHub has redesigned their website.
Comment 3 Michael Catanzaro 2023-06-20 06:59:27 PDT 
Not for me. I think you're part of a test cohort.
Comment 4 Michael Catanzaro 2023-06-20 11:35:28 PDT 
*** Bug 258306 has been marked as a duplicate of this bug. ***
Comment 5 Michael Catanzaro 2023-06-20 13:09:49 PDT 
(In reply to Michael Catanzaro from comment #3)
> Not for me. I think you're part of a test cohort.

Well I've got the new version now. Dang, that's a seriously annoying menu. :P
Comment 6 Calvin Walton 2023-06-28 10:02:10 PDT 
For folks who don't see the updated UI, you may be able to enable it. Under the user menu, choose "Feature preview" and enable "Global Navigation Update".

You may also be able to use that menu to disable it if it has been enabled automatically.
Comment 7 Kdwk 2023-07-22 07:22:08 PDT 
Created attachment 467089 [details]
Screencast showing how to work around the problem

Disabling `display: revert` seems to do the trick
Comment 8 Carlos Garcia Campos 2023-08-02 03:34:50 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/16309
Comment 9 Michael Catanzaro 2023-08-02 05:57:59 PDT 
Good work!

I am going to backport https://commits.webkit.org/261193@main to webkitglib/2.40, which is additionally required to fix this bug in stable.
Comment 10 EWS 2023-08-02 06:05:40 PDT 
Committed 266510@main (476e8fbe38b0): <https://commits.webkit.org/266510@main>

Reviewed commits have been landed. Closing PR #16309 and removing active labels.
Comment 11 Michael Catanzaro 2023-08-02 06:14:33 PDT 
(In reply to Michael Catanzaro from comment #9)
> Good work!
> 
> I am going to backport https://commits.webkit.org/261193@main to
> webkitglib/2.40, which is additionally required to fix this bug in stable.

Hm, the popover attribute doesn't exist in Safari stable at all. But backporting this commit is sufficient to fix the bug with github.com. So I guess I'll do that.

I'm nervous that this is enabling some web feature that is not fully-baked yet and may cause regressions on other websites, because there are lots more recent popover commits that I haven't sorted through and am not backporting, but fixing github.com seems most important.