RESOLVED FIXED258267
[Cocoa] Custom colorspaces in JPEG XL images don't work on downlevels 
https://bugs.webkit.org/show_bug.cgi?id=258267
Summary [Cocoa] Custom colorspaces in JPEG XL images don't work on downlevels
Myles C. Maxfield
Reported 2023-06-18 17:22:23 PDT
We build for downlevels with USE(JPEGXL) but not USE(LCMS). We should port the existing color conversion code to use Core Graphics. The way to do this is: 1. tryDecodeICCColorProfile() can use CGColorSpaceCreateWithICCData() with a CFData 2. Create a CGColorConversionInfo from the source and destination color space 3. Use vImageConverter_CreateWithCGColorConversionInfo() to create a converter 4. vImageConvert_AnyToAny() We might need a custom refptr for the vImageConverter. We can probably do this with custom RefPtr traits, like I did in 264884@main
Attachments
Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2023-06-19 14:50:30 PDT
<rdar://problem/111012276>
Myles C. Maxfield
Comment 2 2023-06-19 14:50:35 PDT
*** Bug 258285 has been marked as a duplicate of this bug. ***
Myles C. Maxfield
Comment 3 2023-06-19 14:55:46 PDT
Pull request: https://github.com/WebKit/WebKit/pull/15098
EWS
Comment 4 2023-06-22 20:11:52 PDT
Committed 265440@main (19b823079b6d): <https://commits.webkit.org/265440@main> Reviewed commits have been landed. Closing PR #15098 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.