258216 – REGRESSION(262277@main): wpt/css/CSS2/floats/floats-rule3-outside-left-001.xht

Bug 258216 - REGRESSION(262277@main): wpt/css/CSS2/floats/floats-rule3-outside-left-001.xht

Summary: REGRESSION(262277@main): wpt/css/CSS2/floats/floats-rule3-outside-left-001.xht

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	Layout and Rendering (show other bugs)
Version:	WebKit Nightly Build
Hardware:	Unspecified Unspecified

Importance:	P2 Normal
Assignee:	zalan

URL:
Keywords:	InRadar

Depends on:
Blocks:

Reported:	2023-06-16 09:21 PDT by Sam Sneddon [:gsnedders]
Modified:	2023-10-30 09:56 PDT (History)
CC List:	5 users (show)

See Also:	254394 209735

Attachments
Patch (7.27 KB, patch) 2023-06-20 12:20 PDT, zalan	no flags	Details \| Formatted Diff \| Diff
[fast-cq]Patch (7.27 KB, patch) 2023-06-20 14:06 PDT, zalan	ews-feeder: commit-queue-	Details \| Formatted Diff \| Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Sam Sneddon [:gsnedders] 2023-06-16 09:21:08 PDT

c.f. https://wpt.fyi/results/css/CSS2/floats?label=master&product=chrome%5Bexperimental%5D&product=firefox%5Bexperimental%5D&product=safari-167%20preview%5Bexperimental%5D&product=safari-172%20preview&product=safari%5Bstable%5D&q=floats-rule3-outside%20%20001

bisect points at 262277@main as the culprit

we don't have this imported in WebKit (bug 209735)

see https://wpt.fyi/results/css/CSS2/floats/floats-rule3-outside-left-001.xht and https://wpt.fyi/results/css/CSS2/floats/floats-rule3-outside-right-001.xht

Comment 1 Radar WebKit Bug Importer 2023-06-16 09:21:20 PDT

<rdar://problem/110903782>

Comment 2 zalan 2023-06-16 10:41:14 PDT

While working on a test reduction I noticed that both Chrome and Firefox let floats overlap
https://jsfiddle.net/65h4eykx/1/
very sus.

Comment 3 zalan 2023-06-20 12:20:17 PDT

Created attachment 466764 [details]
Patch

Comment 4 Antti Koivisto 2023-06-20 12:27:12 PDT

Comment on attachment 466764 [details]
Patch

Gallery quality ASCII art

Comment 5 zalan 2023-06-20 12:31:04 PDT

(In reply to Antti Koivisto from comment #4)
> Comment on attachment 466764 [details]
> Patch
> 
> Gallery quality ASCII art
don't give me ideas

Comment 6 zalan 2023-06-20 14:06:53 PDT

Created attachment 466767 [details]
[fast-cq]Patch

Comment 7 EWS 2023-06-20 20:51:56 PDT

Committed 265345@main (c03d0ac6e6db): <https://commits.webkit.org/265345@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 466767 [details].