Bug 25817 - svg/dom/SVGScriptElement/script-load-and-error-events.svg is flakey
Summary: svg/dom/SVGScriptElement/script-load-and-error-events.svg is flakey
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
: 29700 46998 76558 (view as bug list)
Depends on:
Blocks:
 
Reported: 2009-05-15 01:39 PDT by Eric Seidel (no email)
Modified: 2013-09-13 16:55 PDT (History)
4 users (show)

See Also:

Attachments
improve failure output (4.06 KB, patch)
2013-09-13 15:18 PDT, Alexey Proskuryakov 		no flags Details | Formatted Diff | Diff
proposed fix (1.57 KB, patch)
2013-09-13 16:50 PDT, Alexey Proskuryakov 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2009-05-15 01:39:21 PDT 
svg/dom/SVGScriptElement/script-load-and-error-events.svg is flakey

We need to fix the test so it stops sometimes failing on the bots.   We can also skip it if necessary.

Example failure: http://build.webkit.org/results/Windows%20Debug%20(Tests)/r43761%20(1061)/results.html
Comment 1 Eric Seidel (no email) 2009-09-23 18:19:06 PDT 
*** Bug 29700 has been marked as a duplicate of this bug. ***
Comment 2 Nikolas Zimmermann 2012-02-08 02:22:56 PST 
*** Bug 46998 has been marked as a duplicate of this bug. ***
Comment 3 Nikolas Zimmermann 2012-02-08 02:23:34 PST 
*** Bug 76558 has been marked as a duplicate of this bug. ***
Comment 4 Alexey Proskuryakov 2013-09-13 15:18:13 PDT 
Created attachment 211597 [details]
improve failure output

This test fails very often.

I cannot reproduce locally, and cannot find anything wrong through code inspection. Let's see if this additional information helps.
Comment 5 Tim Horton 2013-09-13 15:20:13 PDT 
Comment on attachment 211597 [details]
improve failure output

View in context: https://bugs.webkit.org/attachment.cgi?id=211597&action=review

> LayoutTests/svg/dom/SVGScriptElement/script-load-and-error-events.svg:-112
> -    scriptElement.href.baseVal = "resources/not-existant.js";

Are you going to move this file, too?
Comment 6 Alexey Proskuryakov 2013-09-13 15:27:05 PDT 
Comment on attachment 211597 [details]
improve failure output

Committed <http://trac.webkit.org/r155727>, clearing review flag.
Comment 7 Alexey Proskuryakov 2013-09-13 16:41:01 PDT 
OK, so it says "FAIL: The following tests failed: 6 (actual result: )". 

This means that we are not done running tests 1-5 when we start test 6. One of those gets into errorEventHandler, and since lastTest variable is set, we get into endTest().
Comment 8 Alexey Proskuryakov 2013-09-13 16:43:31 PDT 
Oh, but of course. Test 5 is expected to generate a load event first, and then an error event. We start test 6 as soon as we get the load event from test 5.
Comment 9 Alexey Proskuryakov 2013-09-13 16:50:59 PDT 
Created attachment 211603 [details]
proposed fix
Comment 10 Alexey Proskuryakov 2013-09-13 16:55:29 PDT 
Committed <http://trac.webkit.org/r155733>.