Bug 25814 - m_spreadMethod accessed without initialization
Summary: m_spreadMethod accessed without initialization
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Images (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: Nobody
URL: LayoutTests/fast/canvas/canvas-radial...
Keywords:
Depends on:
Blocks:
 
Reported: 2009-05-14 17:17 PDT by Rahul Kuchhal
Modified: 2009-05-14 22:39 PDT (History)
0 users

See Also:


Attachments
Patch (1.00 KB, patch)
2009-05-14 17:19 PDT, Rahul Kuchhal
darin: review+
Details | Formatted Diff | Diff
new patch without the tabs this time (1.01 KB, patch)
2009-05-14 21:03 PDT, Rahul Kuchhal
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rahul Kuchhal 2009-05-14 17:17:34 PDT
m_spreadMethod is not getting initialized in one of the constructors.

Will append the patch in a minute.
Comment 1 Rahul Kuchhal 2009-05-14 17:19:47 PDT
Created attachment 30364 [details]
Patch
Comment 2 Darin Adler 2009-05-14 19:31:12 PDT
Comment on attachment 30364 [details]
Patch

> +        Initialize m_spreadMethod in the second constructor too. Not sure if
> +	a test case can be written, so no test case.
> +	https://bugs.webkit.org/show_bug.cgi?id=25814

The tabs in this ChangeLog will cause extra work for whoever commits the patch.
Comment 3 Rahul Kuchhal 2009-05-14 21:03:37 PDT
Created attachment 30365 [details]
new patch without the tabs this time
Comment 4 Eric Seidel (no email) 2009-05-14 22:39:45 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/platform/graphics/Gradient.cpp
Committed r43755

Thanks for the patch!